Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CryptoTransferHandler.validate() #4887

Closed
Tracked by #5526
netopyr opened this issue Feb 7, 2023 · 2 comments
Closed
Tracked by #5526

Implement CryptoTransferHandler.validate() #4887

netopyr opened this issue Feb 7, 2023 · 2 comments
Labels
Modularization Issues or PRs related to modularization

Comments

@netopyr
Copy link
Contributor

netopyr commented Feb 7, 2023 •
edited by nickpoorman
Loading

Add the precheck logic to CryptoTransferHander.

Each query has a payment CryptoTransfer transaction which need to be validated if there are any invalid fields/values in it.

Currently that functionality to validate is present in CryptoTransferTransistionLogic.validateSemantics().

The functionality from CryptoTransferTransistionLogic.validateSemantics() needs to be migrated to CryptoTransferHandler.validate().
@netopyr netopyr mentioned this issue Feb 7, 2023
Closed
7 tasks
@netopyr netopyr added the Modularization Issues or PRs related to modularization label Feb 7, 2023
@nickpoorman
Copy link
Contributor

There is currently an adapter and the adapter needs to be removed in a future iteration.

@nickpoorman nickpoorman mentioned this issue Mar 8, 2023
Closed
3 tasks
@Neeharika-Sompalli
Copy link
Member

Duplicate of #5805

@Neeharika-Sompalli Neeharika-Sompalli marked this as a duplicate of #5805 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Modularization Issues or PRs related to modularization
Projects
Services Sprint Tracking
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickpoorman @netopyr @Neeharika-Sompalli