Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement e2e tests for cluster command #137

Closed
Tracked by #50
leninmehedy opened this issue Mar 6, 2024 · 2 comments · Fixed by #179
Closed
Tracked by #50

Implement e2e tests for cluster command #137

leninmehedy opened this issue Mar 6, 2024 · 2 comments · Fixed by #179
Assignees
Labels
Improvement Code changes driven by non business requirements released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Mar 6, 2024

We need to implement e2e tests for solo cluster command. The test suite should create its own cluster in beforeAll() assuming kind is available on the machine:

TODO

  • Create a new e2e test suite called: test/e2e/commands/cluster.test.mjs (remove other sequence number from other test files)
  • We shall run it in its own cluster, e.g. solo-test-cluster-cmd
  • Implement the e2e following structure as below:
describe('ClusterCommand` () => {
    beforeAll(async() => {
      await clusterCmd.Run('kind create cluster -n ${cluster-name})
    )
    
    afterAll(async() => {
      await clusterCmd.Run('kind delete cluster -n ${cluster-name})
    })

    it('solo cluster setup should fail with invalid cluster name', () => {
    })
    
    it('solo cluster setup should work with valid args', () => {
    })

    it('solo cluster reset should fail with invalid cluster name', () => {
    })
    
    it('solo cluster reset should work with valid args', () => {
    })
})
  • Also please update DEV.md saying that kind is required for development.
@jeromy-cannon jeromy-cannon added the Improvement Code changes driven by non business requirements label Mar 7, 2024
@leninmehedy
Copy link
Member Author

leninmehedy commented Mar 18, 2024

Instead of creating cluster, we should just bootstrapNetwork in a new namespace. This is to reduce test execution time as a new cluster would take a while to load all the images. See the pattern here: https://github.com/hashgraph/solo/pull/159

@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements released
Projects
Status: ✅ Done
4 participants