Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement e2e test for network command #138

Closed
Tracked by #50
leninmehedy opened this issue Mar 6, 2024 · 1 comment · Fixed by #181
Closed
Tracked by #50

Implement e2e test for network command #138

leninmehedy opened this issue Mar 6, 2024 · 1 comment · Fixed by #181
Assignees
Labels
Improvement Code changes driven by non business requirements released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Mar 6, 2024

We need to implement e2e tests for solo network command. The test suite should create its own cluster in beforeAll() assuming kind is available on the machine:

TODO

  • Create a new e2e test suite called: test/e2e/commands/network.test.mjs (remove other sequence number from other test files)
  • We shall run it in its own cluster, e.g. solo-test-network-cmd
  • Implement the e2e following structure as below:
describe('NetworkCommand` () => {
    beforeAll(async() => {
      await networkCmd.Run('kind create cluster -n ${cluster-name})
      await clusterCmd.setup(argv)
    )
    
    afterAll(async() => {
      await networkCmd.Run('kind delete cluster -n ${cluster-name})
    })
    
    it('solo network deploy should deploy three network nodes with defaults', () => {
        // no need to add support for ssl for now. So this should test `solo network deploy`
    })
    
    it('solo network destroy should destroy deployed network', () => {
      // this should tests `solo network deploy --delete-pvcs`
    })
})
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements released
Projects
Status: ✅ Done
4 participants