Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helm and java from CI pipeline setup #161

Closed
Tracked by #50
leninmehedy opened this issue Mar 13, 2024 · 1 comment · Fixed by #197
Closed
Tracked by #50

Remove helm and java from CI pipeline setup #161

leninmehedy opened this issue Mar 13, 2024 · 1 comment · Fixed by #197
Assignees
@JeffreyDallas
Labels
Improvement Code changes driven by non business requirements released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Mar 13, 2024 •
edited

Since solo installs helm during solo init we don't need helm to be installed on the system. So CI pipeline could remove its helm installation step.

We also don't need java since keytool is now installed on demand: #152
There are some junit.xml test config file. I believe we don't need those in this nodejs repo anymore.
@leninmehedy leninmehedy mentioned this issue Mar 13, 2024
Open
@leninmehedy leninmehedy added the Improvement Code changes driven by non business requirements label Mar 18, 2024
@leninmehedy leninmehedy changed the title Remove helm from CI pipeline setup Remove helm and java from CI pipeline setup Mar 20, 2024
@JeffreyDallas JeffreyDallas mentioned this issue Apr 1, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDallas JeffreyDallas

Labels
Improvement Code changes driven by non business requirements released
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove helm & java install from ci pipeline hashgraph/solo
3 participants
@leninmehedy @JeffreyDallas @swirlds-automation