Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor update special account keys using Listr #71

Closed
Tracked by #50
leninmehedy opened this issue Feb 26, 2024 · 1 comment · Fixed by #105
Closed
Tracked by #50

Refactor update special account keys using Listr #71

leninmehedy opened this issue Feb 26, 2024 · 1 comment · Fixed by #105
Assignees
@jeromy-cannon
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Feb 26, 2024 •
edited

Currently it uses an array of promises to attempt to update all account keys at the same time. It would have been better to use Listr and create separate sub-tasks where we can control sequential or parallel execution as well as provide better updates in the console for user.
@leninmehedy leninmehedy added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Feb 26, 2024
@jeromy-cannon jeromy-cannon added the P3 Low priority issue. Will not impact the release schedule if not complete. label Feb 26, 2024
@leninmehedy leninmehedy self-assigned this Feb 29, 2024
@jeromy-cannon jeromy-cannon mentioned this issue Feb 29, 2024
Merged
@leninmehedy leninmehedy mentioned this issue Mar 4, 2024
Open
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromy-cannon jeromy-cannon

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. released
Projects
Solo
Status: ✅ Done
Milestone
No milestone
3 participants
@leninmehedy @jeromy-cannon @swirlds-automation