Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await Session Setup #116

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Await Session Setup #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/app/routes/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class ApplicationRoute extends Route {
}

async beforeModel() {
this.session.setup();
await this.session.setup();

// Flags read from the environment and set properties on the service this
// could be done in an initializer, but this seems more natural these days
Expand Down
2 changes: 1 addition & 1 deletion web/types/ember-simple-auth/services/session.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface Data {
declare module "ember-simple-auth/services/session" {
export default class EmberSimpleAuthSessionService extends Service.extend(Evented) {
data: Data;
setup: () => void;
setup(): Promise<void>;
authenticate(...args: any[]): RSVP.Promise;
invalidate(...args: any): RSVP.Promise;
requireAuthentication(
Expand Down