Approver list refactor and bug fix #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreda
approved these changes
May 30, 2023
jeffdaley
commented
May 30, 2023
| @@ -215,7 +215,7 @@ | |||
| <ol class="person-list"> | |||
| {{#each this.approvers as |approver|}} | |||
| <li> | |||
| <Person | |||
| <Person::Approver | |||
| @imgURL={{approver.imgURL}} | |||
There was a problem hiding this comment.
This component was missing a @badge property
Merged
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Add badge to Approvers list (owner view) * Component-ize Approvers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where approver badges were not displaying for document owners. Makes the approver "Person" its own component.