Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Tweak front-end error messages" #200

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Jun 5, 2023

Reverts #198 which turned out to be unhelpful.

Logs fetch error responses so we can inspect them.

@jeffdaley jeffdaley changed the title Revert "WIP: Tweak front-end error messages" Revert "Tweak front-end error messages" Jun 5, 2023
@jeffdaley jeffdaley marked this pull request as ready for review June 6, 2023 17:41
@jeffdaley jeffdaley requested a review from a team as a code owner June 6, 2023 17:41
@jeffdaley jeffdaley merged commit 3aa799d into main Jun 6, 2023
1 check passed
@jeffdaley jeffdaley deleted the revert-198-jeffdaley/update-error-messages branch June 6, 2023 17:46
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
* Revert "WIP: Tweak front-end error messages (hashicorp-forge#198)"

This reverts commit e6a51f5.

* Add console.log

* Add comment to console.error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants