New::DocForm updates: TypeScript, error handling, documentation, discourage long summaries
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
New::DocForm updates: TypeScript, error handling, documentation, discourage long summaries
jeffdaley
commented
Feb 10, 2023
Comment on lines
-1
to
-4
| export interface DocumentPerson { | ||
| email: string; | ||
| imgURL: string | null; | ||
| } |
There was a problem hiding this comment.
Moved to web/app/types/document.d.ts
…-forge/hermes into jeffdaley/new-doc-form
jfreda
reviewed
Mar 7, 2023
web/app/components/new/doc-form.ts
Outdated
| }), | ||
| }); | ||
|
|
||
| throw new Error(); |
There was a problem hiding this comment.
Was this for testing and should be removed?
There was a problem hiding this comment.
😅😬🫠 thanks for catching
jfreda
approved these changes
Mar 7, 2023
anuragprafulla
referenced
this pull request
in razorpay/hermes
Jun 27, 2023
…scourage long summaries (#21) * Type DocForm; Discourage long summaries; Cleanup * Cleanup * Rearrange interfaces * Update yarn.lock * Cleanup * Refactor updateFormElements actions * Refactor updateFormElements actions * Add comment * Update doc-form.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following changes to the
New::DocForm:PeopleSelectcomponentcreateDocerror (shows flashMessage; preserves formFields)Plus some renaming, for clarity :-)
CleanShot.2023-02-02.at.18.07.08.mp4