Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some Dropdown-related properties #231

Merged
merged 9 commits into from
Jun 23, 2023
Merged

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Jun 22, 2023

Changes the name of some selected properties to isSelected to differentiate them from other selected properties.

In the context of DropdownLists, we use selected in two ways:

  1. "Among a list, which item(s) [are] selected?"
  2. "Is this item selected?"

It's hard to remember which one is which, so I'm renaming the latter cases.

Here's a quick visualization of the changes:
CleanShot 2023-06-22 at 10 01 34@2x

@jeffdaley jeffdaley marked this pull request as ready for review June 22, 2023 01:49
@jeffdaley jeffdaley requested a review from a team as a code owner June 22, 2023 01:49
@jeffdaley jeffdaley marked this pull request as draft June 22, 2023 01:54
@jeffdaley jeffdaley marked this pull request as ready for review June 22, 2023 14:07
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@jeffdaley jeffdaley merged commit 0795291 into main Jun 23, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/rename-selected branch June 23, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants