EditableField types and tests #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jun 27, 2023
| @@ -288,7 +288,6 @@ | |||
| @field={{field}} | |||
| @attributes={{attributes}} | |||
| @onChange={{perform this.save field}} | |||
| @updateFieldValue={{this.updateCustomFieldValue}} | |||
There was a problem hiding this comment.
This wasn't being used (anymore?) as far as I could tell.
|
|
||
| export const FOCUSABLE = | ||
| 'button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])'; | ||
|
|
||
| export default class EditableField extends Component { | ||
| @tracked editing = false; | ||
| @tracked element = null; |
There was a problem hiding this comment.
element is a protected propertyName according to Glint/TS so I changed it to el
jfreda
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the broader result of the #243 bug: more precisely typed and tested CustomEditableField components.