Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX for string-based EditableFields #301

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Improve UX for string-based EditableFields #301

merged 3 commits into from
Aug 23, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Aug 21, 2023 •
edited
Loading

Updates the functionality of the EditableField component:

  • Enter will now commit your changes and Escape will cancel them.
  • You can now submit an empty value on a non-required field to clear a previous value.
  • Submitting an empty value on a required field now shows an error message.

Plus some refactors, tests and documentation.

@jeffdaley jeffdaley changed the title Jeffdaley/editable textfield Improve UX for string-based EditableFields Aug 21, 2023
@jeffdaley jeffdaley marked this pull request as ready for review August 21, 2023 21:19
@jeffdaley jeffdaley requested a review from a team as a code owner August 21, 2023 21:19
@jeffdaley jeffdaley added the enhancement New feature or request label Aug 21, 2023
jfreda
jfreda approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jeffdaley jeffdaley merged commit b82acac into main Aug 23, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/editable-textfield branch August 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda