EditableFields enhancements and bugfixes #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffdaley
commented
Sep 15, 2023
•
jeffdaley
commented
- Adds new hover and focus affordances for editable fields
- Adds Save and Cancel buttons when in edit mode
- Simplifies sidebar markup
- Adds keyboard support to PeopleSelect
- Fixes bugs around cancelling/submitting PeopleSelect inputs, including CustomEditablePeopleFields
- Adds interactivity to RelatedResources EmptyState
- Adds tests
jeffdaley
changed the title
jeffdaley
changed the title
jfreda
approved these changes
Oct 5, 2023
Comment on lines
+5
to
+7
| @value={{if this.typeIsString this.stringValue this.hermesUsers}} | ||
| @onChange={{if this.typeIsPeople this.onPeopleSelectChange}} | ||
| @onSave={{if this.typeIsPeople this.onPeopleSave @onSave}} |
There was a problem hiding this comment.
Not necessary for this PR, but it might be good to get ahead of other potential types besides "string" and "people" sooner than later, and handle this in a less binary way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.