Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return undefined instead of null in get-product-id files #387

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

jeffdaley
Copy link
Contributor

Changes the get-product-id files to return undefined instead of null as a fallback. This better matches (and thus passes more Glint checks for) receiving component types, which tend to be more efficient as value?: string rather than value?: string | null

@jeffdaley jeffdaley marked this pull request as ready for review October 26, 2023 01:24
@jeffdaley jeffdaley requested a review from a team as a code owner October 26, 2023 01:24
@jeffdaley jeffdaley merged commit 633659f into main Oct 27, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/get-product-id branch October 27, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants