Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine My Docs and My Drafts #420

Merged
merged 99 commits into from
Nov 29, 2023
Merged

Combine My Docs and My Drafts #420

merged 99 commits into from
Nov 29, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Nov 15, 2023

My Docs

CleanShot 2023-11-22 at 13 23 59@2x
  • Combines the /drafts and /my routes into a view at /my/documents
  • Replaces facet filters with a single toggle to show/hide drafts you're collaborating on.
  • Groups documents by modified date, e.g., "Recently active" and "More than 30 days old"
  • Increases the number of docs per page to minimize the need for extra controls

Why remove filtering?

Primary to simplify the UX. Most users don't yet have enough docs to make filtering necessary. The use case isn't there the same way it is for All Docs, where there's thousands of docs spread across dozens of products. We're also under the current limitation of Drafts and Published Docs being on separate indexes, which makes filtering (let alone pagination) a high-cost, low-value task. Long-term, I expect we'll add back some lightweight filters, but it'll be once Drafts and Docs are a single index.

@jeffdaley jeffdaley marked this pull request as ready for review November 22, 2023 19:07
@jeffdaley jeffdaley requested a review from a team as a code owner November 22, 2023 19:07
@jeffdaley jeffdaley changed the title WIP: Combine My Docs and My Drafts Combine My Docs and My Drafts Nov 22, 2023
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - we should discuss a potential move away from Algolia for drafts in general if we're not going to support searching them, and how the Hermes API could enable this for the frontend.

@jeffdaley jeffdaley merged commit 278467d into main Nov 29, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/my branch November 29, 2023 01:41
@anubhavmishra anubhavmishra added the enhancement New feature or request label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants