Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeColumn argument to Table::Row #423

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Add timeColumn argument to Table::Row #423

merged 9 commits into from
Nov 21, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Nov 15, 2023 •
edited
Loading

Adds a timeColumn argument to the Table::Row component to control whether the createdTime or modifiedTime is displayed.

@jeffdaley jeffdaley changed the title PENDING: Add timeColumn argument to Table::Row Add timeColumn argument to Table::Row Nov 15, 2023
@jeffdaley jeffdaley marked this pull request as ready for review November 15, 2023 19:50
@jeffdaley jeffdaley requested a review from a team as a code owner November 15, 2023 19:50
jfreda
jfreda approved these changes Nov 21, 2023
View reviewed changes
web/app/components/table/row.ts Outdated Show resolved Hide resolved
@jeffdaley jeffdaley merged commit 9f1888f into main Nov 21, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/table-time-column branch November 21, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda