New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `projects` to FlagsService; add conditional Projects navLink #434

Merged

jeffdaley merged 3 commits into main from jeffdaley/feature-flags

Nov 21, 2023

Contributor

jeffdaley commented Nov 17, 2023 •

edited

Loading

Adds projects getter to the FlagsService
Converts FlagsService to TS
Adds version and short_revision to the HermesConfig type definition
Adds Projects nav link if flag is enabled


          Add projects to FlagsService

cea122c

jeffdaley changed the title ~~Add projects to FlagsService~~ Add projects to FlagsService; add conditional Projects navLink

jeffdaley marked this pull request as ready for review

November 17, 2023 02:16

jeffdaley requested a review from a team as a code owner

November 17, 2023 02:16

jeffdaley added 2 commits

November 17, 2023 12:10


          Remove initialize function

7ce5774


          Fix projects getter; add projects to Mirage config

c9783d7

jfreda approved these changes

View reviewed changes

jeffdaley merged commit 27196b7 into main

2 checks passed

jeffdaley deleted the jeffdaley/feature-flags branch

November 21, 2023 19:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment