Component-ize Project documents (Doc::TileMedium)
#459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Nov 28, 2023
| @@ -71,7 +71,7 @@ | |||
| } | |||
|
|
|||
| .overflow-button-container { | |||
| @apply absolute right-1 top-1; | |||
| @apply absolute right-1 top-1 z-10 h-[calc(100%-16px)] items-start; | |||
There was a problem hiding this comment.
The overflow-button gradient was still slightly visible even after #452
jeffdaley
commented
Nov 28, 2023
Comment on lines
-220
to
+222
| assert | ||
| .dom(DOCUMENT_TYPE) | ||
| .containsText(docType) | ||
| .hasAttribute("href", "/documents?docType=%5B%22PRD%22%5D"); | ||
| assert.dom(DOCUMENT_TYPE).containsText(docType); | ||
|
|
||
| assert | ||
| .dom(DOCUMENT_STATUS) | ||
| .containsText(docStatus) | ||
| .hasAttribute("href", "/documents?status=%5B%22Approved%22%5D"); | ||
| assert.dom(DOCUMENT_STATUS).containsText(docStatus); |
There was a problem hiding this comment.
I removed interactivity from the status and docType tags. The use case for these filters isn't very strong, especially in comparison to docOwner/productArea — themselves debatable as links in this context — so as not to be worth sacrificing the click area.
jeffdaley
changed the title
Doc::TileMedium)
jfreda
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts project-document code into a
Doc::TileMediumcomponent which can be used on other screens. Includes logic to load the ownerPhotos of newly added docs.(I imagine we'll eventually combine the
Doc::Tilecomponents but I'd like to handle that separately.)