Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flight icon to document types configuration #479

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jfreda
Copy link
Contributor

@jfreda jfreda commented Dec 5, 2023

This PR enables a configurable Helios flight icon per document type. The /document-types API response now includes flightIcon per document type (if configured). This will essentially be a breaking change once the hardcoded icons are removed in the web app.

New config option

document_types {
  document_type "RFC" {
    ...
    flight_icon = "discussion-circle"
    ...
  }
}

@jfreda jfreda added the breaking changes PR contains breaking changes label Dec 5, 2023
@jfreda jfreda requested a review from a team as a code owner December 5, 2023 22:57
@jfreda jfreda merged commit 02da840 into main Dec 5, 2023
2 checks passed
@jfreda jfreda deleted the jfreda/add-flight-icon-to-doc-type branch December 5, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes PR contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants