Enable creating documents as logged-in user #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhavmishra
approved these changes
Dec 15, 2023
| // subject = "" | ||
| // token_url = "https://oauth2.googleapis.com/token" | ||
| // client_email = "" | ||
| // create_docs_as_user = true |
There was a problem hiding this comment.
that's one way to make it easy for our users! Great work @jfreda 🎉
| @@ -121,6 +129,7 @@ func ConfigHandler( | |||
| AlgoliaDocsIndexName: cfg.Algolia.DocsIndexName, | |||
| AlgoliaDraftsIndexName: cfg.Algolia.DraftsIndexName, | |||
| AlgoliaInternalIndexName: cfg.Algolia.InternalIndexName, | |||
| CreateDocsAsUser: createDocsAsUser, | |||
There was a problem hiding this comment.
Curious why we need to send it in the config?
There was a problem hiding this comment.
I was thinking that we could make the modal that pops up after a draft is created (or at least the text in it about users having to manually manage their notifications) conditional on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables creating documents on behalf of logged-in Hermes users when running Hermes as a service account with domain-wide authority.
New config attribute