feat: add host-set attribute 'only_default' #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new attribute to the plugin host-set named 'only_default' which is a boolean that, if set to true, will only include default ip and dns names from the ec2 instances it finds. A default IP is defined as the primary value on the instance for each attribute. These would be the values that you see in the AWS Console as a column in list view or on the Details tab when selecting a specific instnace. A feature like this is necessary to support dynamic node pools (ASGs) on EKS Clusters where there may be multiple nics attached, and multiple ips per nic; but the host is only listening for SSH connections on the primary NIC/Address. There isn't a good way to specify dynamically which ip to connect to for SSH connections; and it may pick the wrong one (like a pod IP). It will fall back to the primary addresses on the first network device (device index = 0) if those are not set for some reason. Signed-off-by: Justen Walker <justen.walker+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new attribute to the plugin host-set named 'only_default' which is a boolean that, if set to true, will only include default ip and dns names from the ec2 instances it finds.
A default IP is defined as the primary value on the instance for each attribute. These would be the values that you see in the AWS Console as a column in list view or on the Details tab when selecting a specific instnace.
A feature like this is necessary to support dynamic node pools (ASGs) on EKS Clusters where there may be multiple nics attached, and multiple ips per nic; but the host is only listening for SSH connections on the primary NIC/Address. There isn't a good way to specify dynamically which ip to connect to for SSH connections; and it may pick the wrong one (like a pod IP).
It will fall back to the primary addresses on the first network device (device index = 0) if those are not set for some reason.