refactor: 💡 Upgrade Ember to 4.4 LTS within addons/api #1490
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…efactor-upgrade-ember-4-addon-api
addons/api/.github/workflows/ci.yml
Outdated
| @@ -0,0 +1,76 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
What was the purpose of this CI file?
There was a problem hiding this comment.
Good catch! forgot to delete that one.
Context: this file is included by ember cli when you run the upgrade script. I did not went really deep on this, but when I investigate it, basically they check what CI you use, GH workflows in our case, and adds this file to it.
Supposetly, after adding this file, the CI will run this workflow and basically is running ember-try within the CI.
…efactor-upgrade-ember-4-addon-api
* refactor: 💡 Refactor Mirage server configuration Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com>
…efactor-upgrade-ember-4-addon-api
✅ Closes: ICU-6896
…o refactor-upgrade-ember-4-addon-api
| assert.true(model.hasDirtyAttributes); | ||
| assert.true(model.canSave); | ||
| assert.false(model.cannotSave); | ||
| // Should not be able to save while currently saving | ||
| model.transitionTo('updated.inFlight'); | ||
| model.save().then(() => { |
There was a problem hiding this comment.
This should probably be awaited, since it's async.
There was a problem hiding this comment.
@randallmorey this is the part I cherry pick temporarly (until we merge it) from the PR that fixes ember-data issue, here the link. We might want to fix this there 😉
There was a problem hiding this comment.
I actually don't want to await it. This is so I can assert the isSaving transition and then once the promise is resolved assert that it transitioned correctly.
There was a problem hiding this comment.
Ah got it. There may be a way to express this in a way that accomplishes both goals.
There was a problem hiding this comment.
Yup I couldn't figure out a better way to do it, happy to change it if we can think of a better solution
There was a problem hiding this comment.
Made a suggestion. I wanted to make the await explicit for readability. While it probably works without await, that's because Ember tests automagically await the runloop. It's perfectly valid, but might be confusing for anyone new to Ember.
There was a problem hiding this comment.
Looks good, made the change in the other PR
Description
Be aware:
refactor-upgrade-ember-4long living branch.