Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group members api #148

Merged
4 commits merged into from
Sep 1, 2020
Merged

Group members api #148

4 commits merged into from
Sep 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2020

Adds API support for group members.

group.addMembers(['id'])
group.removeMembers(['id'])
group.removeMember('id')

@ghost ghost requested a review from gsusmi September 1, 2020 16:05
Copy link
Collaborator

@gsusmi gsusmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. LGTM. Ty!

addons/api/addon/models/group.js Outdated Show resolved Hide resolved
addons/api/addon/models/group.js Show resolved Hide resolved
Co-authored-by: Susmitha Girumala <susmitha@hashicorp.com>
@ghost ghost merged commit 4386e95 into develop Sep 1, 2020
@ghost ghost deleted the feature-group-members-api branch September 1, 2020 20:56
ghost pushed a commit that referenced this pull request Jun 14, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant