Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 create form for json credentials #1498

Merged
merged 28 commits into from
Dec 13, 2022
Merged

feat: 🎸 create form for json credentials #1498

merged 28 commits into from
Dec 13, 2022

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Nov 23, 2022 •
edited

✅ Closes: ICU-6682

🎟️ Jira ticket
🧑‍💻 Admin preview

Description

Form for creating json credentials
Just a draft for now because I need to add code editor, info field comp., and hds radio cards.

@vercel
Copy link

vercel bot commented Nov 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 13, 2022 at 0:22AM (UTC)
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 13, 2022 at 0:22AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
boundary-ui-storybook ⬜️ Ignored (Inspect) Dec 13, 2022 at 0:22AM (UTC)

@lisbet-alvarez lisbet-alvarez marked this pull request as ready for review December 5, 2022 22:37
@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner December 5, 2022 22:37
@calcaide
Copy link
Collaborator

calcaide commented Dec 9, 2022

Cameron and I reviewed changes within yarn.lock. As you can see there are no changes within package.json and the only changes reflected within yarn.lock is the integrity sha. Before sha1 now sha512. As per my understanding (this post made me realize) this change reflects an upstream change not related to us but to the registry.
Anyway is better to have sha512 rather than sha1 so we do not think this will cause any issues.

ZedLi
ZedLi requested changes Dec 9, 2022
View reviewed changes
ui/admin/app/components/form/credential/json/index.hbs Show resolved Hide resolved
ui/admin/app/abilities/credential.js Show resolved Hide resolved
ui/admin/app/abilities/credential.js Outdated Show resolved Hide resolved
ghost
ghost approved these changes Dec 12, 2022
View reviewed changes
addons/api/addon/models/credential.js

export default class CredentialModel extends GeneratedCredentialModel {
// =attributes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave this? Minor, non-blocking suggestion.

@cameronperera cameronperera merged commit e418017 into main Dec 13, 2022
@cameronperera cameronperera deleted the ICU-6682-create-json-credentials branch December 13, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedLi ZedLi ZedLi approved these changes

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

@dvonanderson dvonanderson Awaiting requested review from dvonanderson

@calcaide calcaide Awaiting requested review from calcaide

@cameronperera cameronperera Awaiting requested review from cameronperera

Assignees

@cameronperera cameronperera

Labels
addons admin api-addon ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lisbet-alvarez @calcaide @cameronperera @ZedLi @DhariniJeeva