Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Eventer along with all of its dependencies #1276

Merged
merged 13 commits into from Jun 6, 2021
Merged

add support for Eventer along with all of its dependencies #1276

merged 13 commits into from Jun 6, 2021

Conversation

jimlambrt
Copy link
Collaborator

@jimlambrt jimlambrt commented Jun 3, 2021 •
edited

This is second of 3 PRs to add the events package and they should be reviewed in order. Before this was #1275 and after this one there's #1277.

This PR will be merged into the branch for #1275, which will be merged to main when all three have been reviewed/approved.

@github-actions github-actions bot added the core label Jun 3, 2021
@jimlambrt jimlambrt mentioned this pull request Jun 4, 2021
Merged
@jimlambrt jimlambrt requested a review from schristoff June 4, 2021 00:01
@jimlambrt jimlambrt mentioned this pull request Jun 4, 2021
Merged
schristoff
schristoff reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer_retry.go Show resolved Hide resolved
louisruch
louisruch reviewed Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and suggestion but this is looking great, looking forward to having all of this in Boundary!

internal/observability/events/eventer.go Outdated Show resolved Hide resolved
internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer.go Outdated Show resolved Hide resolved
internal/observability/events/eventer.go Outdated Show resolved Hide resolved
internal/observability/events/eventer.go Outdated Show resolved Hide resolved
internal/observability/events/eventer.go Outdated Show resolved Hide resolved
internal/observability/events/eventer_retry.go Show resolved Hide resolved
internal/observability/events/eventer_retry.go Outdated Show resolved Hide resolved
internal/observability/events/options.go Show resolved Hide resolved
@jimlambrt @louisruch
Update internal/observability/events/eventer.go
4cbfcd5 
Co-authored-by: Louis Ruch <louisruch@gmail.com>
@jimlambrt @louisruch
Update internal/observability/events/eventer.go
949443f 
Co-authored-by: Louis Ruch <louisruch@gmail.com>
@jimlambrt @louisruch
Update internal/observability/events/eventer.go
e752e85 
Co-authored-by: Louis Ruch <louisruch@gmail.com>
@jimlambrt @louisruch
Update internal/observability/events/eventer.go
e189309 
Co-authored-by: Louis Ruch <louisruch@gmail.com>
@jimlambrt @louisruch
Update internal/observability/events/eventer.go
fa8b873 
Co-authored-by: Louis Ruch <louisruch@gmail.com>
vancluever
vancluever reviewed Jun 4, 2021
View reviewed changes
internal/observability/events/event_delivery_guarantee.go Outdated Show resolved Hide resolved
internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer.go Show resolved Hide resolved
internal/observability/events/eventer_retry.go Show resolved Hide resolved
internal/observability/events/eventer_test.go Show resolved Hide resolved
internal/observability/events/options.go Show resolved Hide resolved
internal/observability/events/testing.go Show resolved Hide resolved
internal/observability/events/testing.go Show resolved Hide resolved
@jimlambrt jimlambrt requested a review from vancluever June 4, 2021 23:41
louisruch
louisruch approved these changes Jun 5, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! this all looks great 🚢

vancluever
vancluever approved these changes Jun 5, 2021
View reviewed changes
Copy link
Contributor

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM here!

@jimlambrt jimlambrt merged commit 6ba8327 into jimlambrt-o11y-base-types Jun 6, 2021
@jimlambrt jimlambrt deleted the jimlambrt-o11y-eventer branch June 6, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisruch louisruch louisruch approved these changes

@vancluever vancluever vancluever approved these changes

@schristoff schristoff Awaiting requested review from schristoff

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jimlambrt @louisruch @vancluever @schristoff