Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded hclog dependencies as we move forward with events #1433

Merged
merged 3 commits into from Aug 1, 2021
Merged

Remove unneeded hclog dependencies as we move forward with events #1433

merged 3 commits into from Aug 1, 2021

Conversation

jimlambrt
Copy link
Collaborator

No description provided.

@jimlambrt jimlambrt requested a review from jefferai July 31, 2021 00:53
@jimlambrt jimlambrt requested a review from louisruch July 31, 2021 00:55
louisruch
louisruch approved these changes Jul 31, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

jefferai
jefferai approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jimlambrt jimlambrt merged commit 68dd2a6 into main Aug 1, 2021
@jimlambrt jimlambrt deleted the jimlambrt-logger-cleanup branch August 1, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

@louisruch louisruch louisruch approved these changes

Assignees
No one assigned
Labels
core/auth core/kms core/lib core/servers core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimlambrt @jefferai @louisruch