Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(config): Add go-sockaddr templating support to Controller and Worker Addresses #1731

Merged
merged 2 commits into from Nov 30, 2021
Merged

feature(config): Add go-sockaddr templating support to Controller and Worker Addresses #1731

merged 2 commits into from Nov 30, 2021

Conversation

hugoghx
Copy link
Collaborator

@hugoghx hugoghx commented Nov 18, 2021

On the back of hashicorp/go-secure-stdlib#14, add support for this templating as a way to set up Controller and Worker addresses in config.

@github-actions github-actions bot added the core label Nov 18, 2021
hugoghx
hugoghx commented Nov 18, 2021
View reviewed changes
internal/cmd/base/servers.go Outdated Show resolved Hide resolved
@hugoghx hugoghx marked this pull request as ready for review November 18, 2021 13:49
tmessi
tmessi previously approved these changes Nov 23, 2021
View reviewed changes
@hugoghx hugoghx force-pushed the hugoamvieira-gosockaddr-template-support branch from 1459fb1 to 4312c2a Compare November 23, 2021 14:16
@hugoghx hugoghx requested a review from tmessi November 23, 2021 14:18
jefferai
jefferai reviewed Nov 26, 2021
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...can you update the website docs for those parameters? Also please add a changelog entry.

@hugoghx
Copy link
Collaborator Author

hugoghx commented Nov 29, 2021 •
edited

@jefferai In terms of the Changelog, I'd have to put this change under a version right? Should I just bump it to 0.7.2?

@louisruch has clarified this, thanks!

test(servers base): add tests ahead of functionality change
21a771b 
Adds tests to `SetupControllerPublicClusterAddress` and
`SetupWorkerPublicAddress` ahead of changes in these functions to
ensure functionality is preserved.
@hugoghx hugoghx force-pushed the hugoamvieira-gosockaddr-template-support branch from c4cdf55 to d650c0c Compare November 29, 2021 18:37
@hugoghx hugoghx force-pushed the hugoamvieira-gosockaddr-template-support branch from d650c0c to f1063a6 Compare November 30, 2021 14:07
@hugoghx hugoghx merged commit 29bdc22 into main Nov 30, 2021
@hugoghx hugoghx deleted the hugoamvieira-gosockaddr-template-support branch November 30, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai left review comments

@tmessi tmessi tmessi approved these changes

@louisruch louisruch Awaiting requested review from louisruch

@mgaffney mgaffney Awaiting requested review from mgaffney

Assignees
No one assigned
Labels
core docs/configuration website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugoghx @jefferai @tmessi