Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller-led worker auth flow #2413

Merged
merged 22 commits into from Sep 2, 2022
Merged

Conversation

jefferai
Copy link
Member

@jefferai jefferai commented Aug 31, 2022

Takes advantage of the improvements in hashicorp/nodeenrollment#30 to allow pulling an activation token from a controller and submitting it to a worker via config.

This adds an action to the API that allows pulling out an activation
token that can be given to a worker in its config (directly or via env
or file). The worker can pass this along with its normal request in
place of its normal nonce and the server will automatically accept it.
@jefferai jefferai added this to the 0.10.4 milestone Aug 31, 2022
@jefferai jefferai marked this pull request as ready for review August 31, 2022 18:45
Co-authored-by: Irena Rindos <irenarindos@users.noreply.github.com>
Copy link
Collaborator

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just had a few comments that might be helpful.

internal/server/repository_worker.go Outdated Show resolved Hide resolved
internal/daemon/worker/worker.go Show resolved Hide resolved
internal/server/worker_auth_server_led_activation_token.go Outdated Show resolved Hide resolved
@jefferai jefferai merged commit 01fb949 into main Sep 2, 2022
@jefferai jefferai deleted the jefferai-server-led-workers branch September 2, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants