Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject Custom Response Headers By Status #2587

Merged
merged 8 commits into from
Dec 1, 2022

Conversation

kheina
Copy link
Collaborator

@kheina kheina commented Nov 2, 2022

relies on go-secure-stdlib#49 and go-secure-stdlib#51
Preview documentation page

tested using boundary-local-env and performing a login via the frontend

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start!

internal/daemon/controller/handler.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extensive docs, I'm tagging @Dan-Heath for a look at this as well

go.mod Outdated Show resolved Hide resolved
internal/daemon/controller/handler.go Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation! I think it reads well and makes sense. I added some minor suggestions for style and grammar. Please let me know if you have any questions about them.

website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
website/content/docs/configuration/listener/tcp.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kheina kheina force-pushed the daniellemiu_add-custom-response-headers branch from d880fb1 to a313dd1 Compare November 23, 2022 17:48
Copy link
Member

@tmessi tmessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise looks good to me

internal/daemon/controller/handler.go Outdated Show resolved Hide resolved
@kheina kheina merged commit 5f8d292 into main Dec 1, 2022
@kheina kheina deleted the daniellemiu_add-custom-response-headers branch December 1, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants