-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign a Network Address to a Target #2613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be targeting the release branch? I assume not.
internal/proto/controller/api/resources/targets/v1/target.proto
Outdated
Show resolved
Hide resolved
From what I know, that's how we're doing things now. We're not targeting |
Uh, I thought that was the case until we were doing a release, but I suppose you could be onto something, good point! |
Lets just make sure we don't merge this until 0.11.1 is out the door 😁 |
9ed72da
to
adea4f9
Compare
adea4f9
to
33e1817
Compare
3bc9748
to
5eac587
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the changelog
internal/db/schema/migrations/oss/postgres/70/03_wh_sessions.up.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CHANGELOG needs an update too 😄
This comment was marked as resolved.
This comment was marked as resolved.
Rebasing off of main and squashing everything back into the original 10 commits now |
3103e4f
to
f43fb15
Compare
This commit adds CLI support for addresses to be attached directly to a Target, for all current types of Target (ssh and tcp). It also clarifies the relevant documentation regarding the autogen of API option functionality.
Targets are not guaranteed to have Host Ids anymore, so we now use Target Id when a Host Id is not present.
This test uses the target domain repository code to test the ingress & egress worker filter. With our changes we have updated the target domain repository logic to fetch the target address. When this migration test is invoked, the target_address table does not exist and the domain code will always return an error making this test invalid.
Creates a target using an address for boundary dev and when first init-ing boundary (boundary database init). It also makes this newly created target the default one (ttcp_1234567890). The target using host sources is now a secondary target (ttcp_0987654321).
Co-authored-by: Hugo <hugoamvieira@users.noreply.github.com>
cf14579
to
b3ba9c5
Compare
Summary:
This branch contains a set of commits that enable a Boundary Target to be directly configured with an address to create a session against, instead of having to create Host Catalogs, Host Sources and Hosts.
How to use (CLI):
Creating a tcp target with an address:
Updating a tcp target with an address:
Removing an address from a target:
Notes:
Example of the error:
Note: grpc-gateway maps Failed Precondition errors into http bad request errors because
this deliberately doesn't translate to the similarly named '412 Precondition Failed' HTTP response status.
Concerns:
Important: We also have Terraform changes to implement client support for a Target using an address. Merging and releasing a provider with those changes is blocked until a Boundary version with the changes in this PR is released. After that, we can update the module imports on the PR and create a new Terraform provider release there.