fix(cli): Status code on api error #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talanknight
approved these changes
Feb 1, 2023
tmessi
force-pushed
the
llb-vault-ssh-cert-injection
branch
from
15c5fb5
to
8c6e0f1
Compare
tmessi
requested review from
sarahethompson and
jeanneryan
and removed request for
a team
tmessi
force-pushed
the
llb-vault-ssh-cert-injection
branch
from
8c6e0f1
to
accda14
Compare
tmessi
force-pushed
the
tmessi-fix-cli-ui-tests
branch
from
6546fcf
to
5bdfa05
Compare
moduli
reviewed
Feb 2, 2023
| got=$(echo "$output") | ||
|
|
||
| run field_eq "$got" ".item.attributes.key_type" '"ecdsa"' | ||
| [ "$status" -eq 0 ] |
There was a problem hiding this comment.
Do you want an echo "$output" here to get debug info from field_eq?
There was a problem hiding this comment.
I am not sure how useful it is. The message from jq isn't the greatest. The output from the read_credential_library should already show the full json that is being used for the comparison.
tmessi
force-pushed
the
llb-vault-ssh-cert-injection
branch
from
accda14
to
a88bcc2
Compare
tmessi
force-pushed
the
tmessi-fix-cli-ui-tests
branch
from
a8581fc
to
f95c0ef
Compare
tmessi
force-pushed
the
llb-vault-ssh-cert-injection
branch
from
a88bcc2
to
8624819
Compare
tmessi
force-pushed
the
tmessi-fix-cli-ui-tests
branch
from
f95c0ef
to
5540d39
Compare
This ensures that checks for features should work, and bails early if
that is not the case, since if this fails the binary is essentially
broken. This also simplifies code that performs these checks, ie instead
of:
binaryVersion, err := version.GetReleaseVersion()
if err != nil {
// handle error? panic?
}
if version.SupportsFeature(binaryVersion, version.FeatureA) {
// code for FeatureA
} else {
// without FeatureA
}
Implementations can do:
if version.SupportsFeature(version.Binary, version.FeatureA) {
// code for FeatureA
} else {
// without FeatureA
}
When using the json output of the cli (`-format=json`), a successful call to the controller API would place the HTTP status code in the JSON as `status_code`. However, if there was an error from the API the status code would be placed in the JSON as `status`. In order to be consistent, this adds a `status_code` field to the error response case. For backwards compatibility it still populates `status` in the error case. This inconsistency was missed partially due to a bug in the CLI tests. The assertion on status code was not valid and would always be successful. Thus this also fixes the assertions and tests.
This adds tests for updating specific fields of the credential library.
tmessi
force-pushed
the
tmessi-fix-cli-ui-tests
branch
from
d9d9957
to
f9a2f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the json output of the cli (
-format=json), a successful callto the controller API would place the HTTP status code in the JSON as
status_code. However, if there was an error from the API the status codewould be placed in the JSON as
status. In order to be consistent, thisadds a
status_codefield to the error response case. For backwardscompatibility it still populates
statusin the error case.This inconsistency was missed partially due to a bug in the CLI tests. The
assertion on status code was not valid and would always be successful. Thus
this also fixes the assertions and tests.