Skip to content

Commit

Permalink
fix (ldap): increase max tls to 1.3
Browse files Browse the repository at this point in the history
  • Loading branch information
jimlambrt committed Jul 14, 2023
1 parent 1d638dd commit 822334c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions ldap/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,12 @@ func TestClient_NewClient(t *testing.T) {
wantErrIs: ErrInvalidParameter,
wantErrContains: "invalid 'tls_min_version' in config",
},
{
name: "valid-tls-max",
conf: &ClientConfig{
TLSMaxVersion: "tls13",
},
},
{
name: "invalid-tls-max",
conf: &ClientConfig{
Expand Down
2 changes: 1 addition & 1 deletion ldap/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const (
DefaultTLSMinVersion = "tls12"

// DefaultTLSMaxVersion for the ClientConfig.TLSMaxVersion
DefaultTLSMaxVersion = "tls12"
DefaultTLSMaxVersion = "tls13"

// DefaultOpenLDAPUserPasswordAttribute defines the attribute name for the
// openLDAP default password attribute which will always be excluded
Expand Down

0 comments on commit 822334c

Please sign in to comment.