Adds initial implementation of the JWT package #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just an overall observation about errors in the package: as implemented callers are forced to use string matching to test for different errors. perhaps, we should define a set of testable errors (via errors.Is) and always wrap them with context info before returning. More aligned with how the oidc package does this. |
jimlambrt
requested changes
Jan 15, 2021
…ryCAPEM not provided
calvn
reviewed
Jan 19, 2021
calvn
reviewed
Jan 19, 2021
jimlambrt
requested changes
Jan 21, 2021
kalafut
reviewed
Jan 21, 2021
kalafut
reviewed
Jan 21, 2021
kalafut
reviewed
Jan 21, 2021
Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
calvn
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an initial implementation of the JWT package, which provides signature verification and claims set validation for JWTs of the JWS form.
The code in this package is similar to that in both the vault-plugin-auth-jwt and consul JWT auth implementations.
Testing
I've integrated and tested the code in this PR in the common-jwt-lib branch of vault-plugin-auth-jwt.
Tests are intentionally absent from this PR in order to first agree on the API and behavior of the package. I'll be adding tests and additional documentation in a subsequent PR once there is agreement.