Backport of Catalog: Use EndpointSlice and propagate Kubernetes Topol…

…ogy information to synced consul service into release/1.2.x (#3780)

* backport of commit b8e5ece

* backport of commit ee26768

* backport of commit 4a3c209

* backport of commit c11b034

* backport of commit 093826a

* backport of commit 75810ab

* backport of commit f0f1762

* backport of commit 395c4fe

* backport of commit 73ffbcb

* backport of commit cc5d60c

* backport of commit 0d8b7ae

* backport of commit 5dcb453

* backport of commit 09506ba

* Catalog: Use EndpointSlice and propagate Kubernetes Topology information to synced consul service (#3693)

* Use EndpointSlice and propagate zone metadata to consul service

* Fix tests

* Add test for zone metadata

* Cleanup and changelog entry

* Fix clusterrole permissions and type on Informer

* Include region info for NodePort services

* Include topology region for all service types

* Update release note

* Fix tests

* fix sync-catalog-clusterrole and tests

* fix stash conflict

* adding endpoints permission back to sync catalog since it still uses it.

* Fix endpointslice map

* Fix topology region

* Remove region lookups, remove endpoints permissions, use pointers for endpointslice map

* Drop region test

---------

Co-authored-by: John Murret <john.murret@hashicorp.com>

---------

Co-authored-by: jukie <10012479+Jukie@users.noreply.github.com>
Co-authored-by: John Murret <john.murret@hashicorp.com>

.changelog/3693.txt

@@ -0,0 +1,3 @@
+```release-note:improvement
+catalog: Topology zone and region information is now read from the Kubernetes endpoints and associated node and added to registered consul services under Metadata.
+```

charts/consul/templates/sync-catalog-clusterrole.yaml

@@ -14,7 +14,19 @@ rules:
 - apiGroups: [ "" ]
   resources:
   - services
-  - endpoints
+  verbs:
+  - get
+  - list
+  - watch
+{{- if .Values.syncCatalog.toK8S }}
+  - update
+  - patch
+  - delete
+  - create
+{{- end }}
+- apiGroups: ["discovery.k8s.io"]
+  resources:
+  - endpointslices
   verbs:
   - get
   - list
@@ -45,4 +57,4 @@ rules:
   - get
   - list
   - watch
-{{- end }}
+{{- end }}

charts/consul/test/unit/sync-catalog-clusterrole.bats

@@ -56,7 +56,7 @@ load _helpers
       --set 'syncCatalog.enabled=true' \
       --set 'global.enablePodSecurityPolicies=true' \
       . | tee /dev/stderr |
-      yq -r '.rules[2].resources[0]' | tee /dev/stderr)
+      yq -r '.rules[3].resources[0]' | tee /dev/stderr)
   [ "${actual}" = "podsecuritypolicies" ]
 }
 
@@ -83,4 +83,12 @@ load _helpers
       . | tee /dev/stderr |
       yq -c '.rules[0].verbs' | tee /dev/stderr)
   [ "${actual}" = '["get","list","watch","update","patch","delete","create"]' ]
+
+  actual=$(helm template \
+      -s templates/sync-catalog-clusterrole.yaml  \
+      --set 'syncCatalog.enabled=true' \
+      --set 'syncCatalog.toK8S=true' \
+      . | tee /dev/stderr |
+      yq -c '.rules[0].verbs' | tee /dev/stderr)
+  [ "${actual}" = '["get","list","watch","update","patch","delete","create"]' ]
 }