Skip to content

Commit

Permalink
remove todos
Browse files Browse the repository at this point in the history
  • Loading branch information
curtbushko committed Jun 27, 2023
1 parent ab736ae commit 5db1344
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions acceptance/tests/connect/connect_proxy_lifecycle_test.go
Expand Up @@ -134,7 +134,6 @@ func TestConnectInject_ProxyLifecycleShutdown(t *testing.T) {
connHelper.TestConnectionSuccess(t)

// Get static-client pod name
// TODO: is this necessary?
ns := ctx.KubectlOptions(t).Namespace
pods, err := ctx.KubernetesClient(t).CoreV1().Pods(ns).List(
context.Background(),
Expand Down Expand Up @@ -175,12 +174,9 @@ func TestConnectInject_ProxyLifecycleShutdown(t *testing.T) {
})
})

// TODO: If listener draining is enabled, ensure inbound
// If listener draining is enabled, ensure inbound
// requests are rejected during grace period.
// connHelper.TestConnectionSuccess(t)

// TODO: Test that outbound requests start failing after
// shutdown grace period has elapsed but before pod terminates.
} else {
// Ensure outbound requests fail because proxy has terminated
retry.RunWith(&retry.Timer{Timeout: time.Duration(terminationGracePeriod) * time.Second, Wait: 2 * time.Second}, t, func(r *retry.R) {
Expand Down

0 comments on commit 5db1344

Please sign in to comment.