Don't set envoy flag --max-obj-name-len

This flag was deprecated and ignored in Envoy 1.11 and will result
in an error for Envoy 1.15.

CHANGELOG.md

@@ -1,5 +1,16 @@
 ## UNRELEASED
 
+BREAKING CHANGES:
+* Connect: No longer set `--max-obj-name-len` flag when executing `envoy`. This flag
+  was [deprecated](https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.11.0#deprecated)
+  in Envoy 1.11.0 and had no effect from then onwards. It will also result
+  in an error for Envoy >= 1.15.0.
+
+  If you are running any Envoy version >= 1.11.0 this change will have no effect. If you
+  are running an Envoy version < 1.11.0 then you must upgrade Envoy to a newer
+  version. This can be done by setting the `global.imageEnvoy` key in the
+  Consul Helm chart.
+
 IMPROVEMENTS:
 
 * Add an ability to configure the synthetic Consul node name where catalog sync registers services. [[GH-312](https://github.com/hashicorp/consul-k8s/pull/312)]

connect-inject/envoy_sidecar.go

@@ -66,7 +66,6 @@ func (h *Handler) envoySidecar(pod *corev1.Pod, k8sNamespace string) (corev1.Con
 		},
 		Command: []string{
 			"envoy",
-			"--max-obj-name-len", "256",
 			"--config-path", "/consul/connect-inject/envoy-bootstrap.yaml",
 		},
 	}

connect-inject/envoy_sidecar_test.go

@@ -32,7 +32,6 @@ func TestHandlerEnvoySidecar(t *testing.T) {
 	require.NoError(err)
 	require.Equal(container.Command, []string{
 		"envoy",
-		"--max-obj-name-len", "256",
 		"--config-path", "/consul/connect-inject/envoy-bootstrap.yaml",
 	})