Skip to content

Commit

Permalink
test: remove unused workflow inputs (#2589)
Browse files Browse the repository at this point in the history
Changes proposed in this PR:
- Removed unused workflow inputs.
  • Loading branch information
DanStough committed Jul 19, 2023
1 parent f0530d9 commit b3769b1
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 13 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: hashicorppreview/consul-enterprise:1.17-dev # Consul's enterprise version to use in tests. We use this consul image on release branches too
BRANCH: ${{ github.head_ref || github.ref_name }}
CONTEXT: "merge"
SHA: ${{ github.event.pull_request.head.sha || github.sha }}
Expand All @@ -28,4 +27,4 @@ jobs:
repo: hashicorp/consul-k8s-workflows
ref: main
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ env.SHA }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}", "consul-image":"${{ env.CONSUL_IMAGE }}" }'
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ env.SHA }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}" }'
3 changes: 1 addition & 2 deletions .github/workflows/nightly-acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: hashicorppreview/consul-enterprise:1.17-dev # Consul's enterprise version to use in tests
BRANCH: ${{ github.ref_name }}
CONTEXT: "nightly"

Expand All @@ -24,4 +23,4 @@ jobs:
repo: hashicorp/consul-k8s-workflows
ref: main
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}", "consul-image":"${{ env.CONSUL_IMAGE }}" }'
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}" }'
1 change: 0 additions & 1 deletion .github/workflows/nightly-api-gateway-conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: hashicorppreview/consul-enterprise:1.17-dev # Consul's enterprise version to use in tests
BRANCH: ${{ github.ref_name }}
CONTEXT: "nightly"

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/nightly-cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: "not used"
BRANCH: ${{ github.ref_name }}
CONTEXT: "nightly"

Expand All @@ -24,4 +23,4 @@ jobs:
repo: hashicorp/consul-k8s-workflows
ref: main
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}", "consul-image":"${{ env.CONSUL_IMAGE }}" }'
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}" }'
3 changes: 1 addition & 2 deletions .github/workflows/weekly-acceptance-0-49-x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: hashicorppreview/consul-enterprise:1.13-dev # Consul's enterprise version to use in tests
BRANCH: "release/0.49.x"
CONTEXT: "weekly"

Expand All @@ -26,4 +25,4 @@ jobs:
repo: hashicorp/consul-k8s-workflows
ref: main
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}", "consul-image":"${{ env.CONSUL_IMAGE }}" }'
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}" }'
3 changes: 1 addition & 2 deletions .github/workflows/weekly-acceptance-1-0-x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: hashicorppreview/consul-enterprise:1.14-dev # Consul's enterprise version to use in tests
BRANCH: "release/1.0.x"
CONTEXT: "weekly"

Expand All @@ -27,4 +26,4 @@ jobs:
repo: hashicorp/consul-k8s-workflows
ref: main
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}", "consul-image":"${{ env.CONSUL_IMAGE }}" }'
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}" }'
3 changes: 1 addition & 2 deletions .github/workflows/weekly-acceptance-1-1-x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ on:

# these should be the only settings that you will ever need to change
env:
CONSUL_IMAGE: hashicorppreview/consul-enterprise:1.15-dev # Consul's enterprise version to use in tests
BRANCH: "release/1.1.x"
CONTEXT: "weekly"

Expand All @@ -27,4 +26,4 @@ jobs:
repo: hashicorp/consul-k8s-workflows
ref: main
token: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}", "consul-image":"${{ env.CONSUL_IMAGE }}" }'
inputs: '{ "context":"${{ env.CONTEXT }}", "repository":"${{ github.repository }}", "branch":"${{ env.BRANCH }}", "sha":"${{ github.sha }}", "token":"${{ secrets.ELEVATED_GITHUB_TOKEN }}" }'

0 comments on commit b3769b1

Please sign in to comment.