Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename consul client daemonset. #1000

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Rename consul client daemonset. #1000

merged 1 commit into from
Jan 27, 2022

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Jan 26, 2022 •
edited
Loading

Changes proposed in this PR:

  • Append -client to the Consul Client Daemonset.

How I've tested this PR: pipelines

How I expect reviewers to test this PR: 👀

Checklist:

  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin requested review from a team, ndhanushkodi and kschoche and removed request for a team January 26, 2022 20:46
kschoche
kschoche approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thisisnotashwin thisisnotashwin force-pushed the rename-consul-daemonset branch 3 times, most recently from 6e3c5b5 to 324f89f Compare January 27, 2022 03:10
@thisisnotashwin thisisnotashwin merged commit c06e501 into main Jan 27, 2022
@thisisnotashwin thisisnotashwin deleted the rename-consul-daemonset branch January 27, 2022 04:45
@takeda
Copy link

takeda commented Oct 14, 2022

@thisisnotashwin @ishustava @kschoche this change broke the "updateStarategy: OnDelete" step in upgrade listed here: https://developer.hashicorp.com/consul/docs/k8s/upgrade#upgrading-consul-servers
as it forces to replace the DaemonSet and it wasn't well documented.

Any workaround for this (stopping clients from being upgraded before upgrading servers)?

@ishustava
Copy link
Contributor

Hey @takeda

Thanks for calling this out! Would you mind creating a new issue for this so we can track and prioritize this accordingly. Thanks so much!

@takeda takeda mentioned this pull request Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@ishustava ishustava ishustava approved these changes

@ndhanushkodi ndhanushkodi Awaiting requested review from ndhanushkodi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thisisnotashwin @takeda @ishustava @kschoche