Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube svc dns for api gateway sds #1007

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Use kube svc dns for api gateway sds #1007

merged 3 commits into from
Jan 28, 2022

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jan 28, 2022

Previously it was using the pod IP of the controller and then when
gateways were created they were hardcoded to use that pod IP.
This was an issue because if the controller pod dies then there will be
a new pod IP and the gateway will lose its connection to the SDS
service. Instead, this PR changes it to use the kube dns url.

How I've tested this PR:

How I expect reviewers to test this PR:

  • code

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Previously it was using the pod IP of the controller and then when
gateways were created they were hardcoded to use that pod IP.
This was an issue because if the controller pod dies then there will be
a new pod IP and the gateway will lose its connection to the SDS
service. Instead, this PR changes it to use the kube dns url.
@lkysow lkysow merged commit 6f0fae9 into main Jan 28, 2022
@lkysow lkysow deleted the lkysow/api-gateway-sds branch January 28, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants