vault: allow providing auth method path to the connect CA configuration #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
requested review from
a team,
jmurret,
ndhanushkodi and
thisisnotashwin
and removed request for
a team and
jmurret
ndhanushkodi
approved these changes
Feb 11, 2022
| "global.secretsBackend.vault.connectCA.authMethodPath": "kubernetes-dc2", | ||
| "global.secretsBackend.vault.connectCA.rootPKIPath": "connect_root", | ||
| "global.secretsBackend.vault.connectCA.intermediatePKIPath": "dc2/connect_inter", | ||
| "global.secretsBackend.vault.connectCA.additionalConfig": fmt.Sprintf(`"{"connect": [{"ca_config": [{"tls_server_name": "%s-vault"}]}]}"`, vaultReleaseName), |
There was a problem hiding this comment.
Could it be worth having a global.secretsBackend.vault.connectCA.dc value and then generating an authMethodPath and intermediatePKIPath based on that? Or would most folks want to just configure those paths themselves?
There was a problem hiding this comment.
I realize intermediatePKIPath is already a configurable value so maybe it has to be this way
There was a problem hiding this comment.
Yeah I think in most cases we'd want the user to decide how these paths should be configured in their Vault. They'd have to have different intermediate paths per datacenter, but we don't want to necessarily enforce a naming convention for them.
ishustava
force-pushed
the
ishustava/vault-wan-fed-acls
branch
3 times, most recently
from
3f5383c
to
43f6307
Compare
ishustava
force-pushed
the
ishustava/vault-wan-fed-connect-ca
branch
2 times, most recently
from
b02ab29
to
4afdd37
Compare
ishustava
force-pushed
the
ishustava/vault-wan-fed-connect-ca
branch
from
4afdd37
to
94094e2
Compare
geobeau
pushed a commit
to geobeau/consul-k8s
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
authMethodPathto the connect CA vault configuration so that you can use a different kubernetes auth method for a case when you are using a single vault server for multiple kubernetes clusters (WAN federation case).How I've tested this PR:
acceptance tests
How I expect reviewers to test this PR:
馃憖
Checklist: