Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable snapshot agent configuration to be retrieved from vault #1113
Enable snapshot agent configuration to be retrieved from vault #1113
Changes from 6 commits
ee0e9b9
e4e994e
3c756d4
b31597c
838241d
05b14a3
02f0604
2c498dd
066a1ac
7c72a7b
d52f584
a4ece5d
1038278
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to base64 decode it? Does vault kv engine not work with not-encoded config? Or does it encode it for you if similar to k8s secrets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! Let me go back and check that I did not encode as part of the test set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally was. I used json.Marshall() and then saving that to Vault instead of wrapping that result in string() and then saving it. I have a PR with the acceptance test and made the modification there ...since I can test it. This is the commit: 634164a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User has to set up a vault policy and auth role that maps the service account to the policy that has access to the snapshot agent config secret. Configuring it here will assign it in a vault annotation in the snapshot agent deployment so that the vault injector for the snapshot agent config will be authorized.