Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: move changelog entry for GH-1150 to unreleased #1158

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented Apr 12, 2022

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

Copy link
Member

@andrewstucki andrewstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-yu whoops, it looks like I accidentally added the changelog entry to the wrong section -- it's here right now:

* Add a `"consul.hashicorp.com/kubernetes-service"` annotation for pods to specify which Kubernetes service they want to use for registration when multiple services target the same pod. [[GH-1150](https://github.com/hashicorp/consul-k8s/pull/1150)]

Do you think you could drop it in this PR too? 😅 😊

Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok once you remove the existing entry on line 49.

@david-yu david-yu changed the title CHANGELOG: add missing changelog for GH-1150 CHANGELOG: move changelog entry for GH-1150 to unreleased Apr 12, 2022
@david-yu david-yu merged commit f9b6249 into main Apr 12, 2022
@david-yu david-yu deleted the david-yu-changelog-1 branch April 12, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants