Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the consul namespace to be a destination. #1163

Merged
merged 2 commits into from Apr 13, 2022
Merged

Allow the consul namespace to be a destination. #1163

merged 2 commits into from Apr 13, 2022

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Apr 13, 2022

With upcoming consul-enterprise this ns will be valid.

How I've tested this PR:

  • unit tests

How I expect reviewers to test this PR:

  • code

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@lkysow
Allow the consul namespace to be a destination.
6f20167 
With upcoming consul-enterprise this ns will be valid.
@lkysow
changelog
665f981
@lkysow lkysow requested review from a team, ishustava and thisisnotashwin and removed request for a team April 13, 2022 03:39
thisisnotashwin
thisisnotashwin approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😹 nicely done

ishustava
ishustava approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@lkysow lkysow merged commit a00f938 into main Apr 13, 2022
@lkysow lkysow deleted the lkysow/consul-ns branch April 13, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lkysow @ishustava @thisisnotashwin