Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mesh and Ingress Gateway CRDs for 1.12 #1168

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Update Mesh and Ingress Gateway CRDs for 1.12 #1168

merged 1 commit into from
Apr 14, 2022

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Apr 13, 2022 •
edited
Loading

Changes proposed in this PR:

  • Update Mesh and Ingress Gateway CRDs for 1.12
  • Rearrange spec fields in CRDs to match order in Consul structs.
  • Update controller-gen from 0.6.0 to 0.8.0 and update generate command accordingly.
  • Update to latest Consul API and SDK version
  • Update files that were autogenerated

How I've tested this PR:

  • Unit tests.

How I expect reviewers to test this PR:

  • 👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin requested review from a team, curtbushko and ndhanushkodi and removed request for a team April 13, 2022 16:41
@thisisnotashwin thisisnotashwin mentioned this pull request Apr 13, 2022
Closed
curtbushko
curtbushko reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Ashwin! I have a few questions below but nothing major that would be a blocker.

charts/consul/templates/crd-ingressgateways.yaml Show resolved Hide resolved
control-plane/api/v1alpha1/ingressgateway_types_test.go Show resolved Hide resolved
control-plane/api/v1alpha1/zz_generated.deepcopy.go Show resolved Hide resolved
control-plane/api/v1alpha1/ingressgateway_types_test.go Show resolved Hide resolved
ndhanushkodi
ndhanushkodi approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!!

@thisisnotashwin
Update Mesh and Ingress Gateway CRDs for 1.12
561c4dd 
- Rearrange spec fields in CRDs to match order in Consul structs.
- Update controller-gen from 0.6.0 to 0.8.0 and update generate command
  accordingly.
- Update to latest Consul API and SDK version
- Update files that were autogenerated
@thisisnotashwin thisisnotashwin merged commit 8f84ef6 into main Apr 14, 2022
@thisisnotashwin thisisnotashwin deleted the ashwin/update_CRDs_for_1-12 branch April 14, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thisisnotashwin @curtbushko @ndhanushkodi