Add support for ACLs for sync catalog and partitions. #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
force-pushed
the
sync-partitions-acl
branch
4 times, most recently
from
2690246
to
837c9ce
Compare
thisisnotashwin
requested review from
a team,
curtbushko and
t-eckert
and removed request for
a team
thisisnotashwin
force-pushed
the
sync-partitions-acl
branch
2 times, most recently
from
622b0ee
to
f79d04f
Compare
curtbushko
requested changes
Apr 20, 2022
thisisnotashwin
force-pushed
the
sync-partitions-acl
branch
2 times, most recently
from
fa7e353
to
a146285
Compare
curtbushko
approved these changes
Apr 20, 2022
thisisnotashwin
force-pushed
the
sync-partitions-acl
branch
from
a146285
to
198dd0a
Compare
t-eckert
reviewed
Apr 21, 2022
Comment on lines
+112
to
+114
| // On Kind, there are no load balancers but since all clusters | ||
| // share the same node network (docker bridge), we can use | ||
| // a NodePort service so that we can access node(s) in a different Kind cluster. |
There was a problem hiding this comment.
This is a great clarifying comment. 👍🏻
t-eckert
reviewed
Apr 21, 2022
| caKeySecretName := fmt.Sprintf("%s-consul-ca-key", releaseName) | ||
|
|
||
| logger.Logf(t, "retrieving ca cert secret %s from the server cluster and applying to the client cluster", caCertSecretName) | ||
| moveSecret(t, serverClusterContext, clientClusterContext, caCertSecretName) |
There was a problem hiding this comment.
I know you didn't add this function, but I'm wondering if it might be clearer if it were called copySecret. "Move" makes me think that the original instance is no longer there.
thisisnotashwin
force-pushed
the
sync-partitions-acl
branch
8 times, most recently
from
82d0a90
to
80d802c
Compare
thisisnotashwin
force-pushed
the
sync-partitions-acl
branch
from
f80533d
to
04597d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: