Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang.org/x/crypto & golang.org/x/text deps to address CVEs #1189

Merged
merged 2 commits into from Apr 27, 2022

Conversation

finnigja
Copy link
Contributor

@finnigja finnigja commented Apr 26, 2022

Changes proposed in this PR:

Bump golang.org/x/crypto and golang.org/x/text dependencies to address CVE-2022-27291 and CVE-2021-38561 respectively.

There's no known exposure of this issues within the consul-k8s context, but adopting updates for hygiene sake & to reduce vulnerability scanner noise.

Proposed changes are the result of running go get -u golang.org/x/crypto, go get -u golang.org/x/text, and go mod tidy in both of the consul-k8s/control-plane and consul-k8s/cli directories.

How I've tested this PR:

  • Reviewed results of CI-driven tests.

How I expect reviewers to test this PR:

  • Review results of CI-driven tests.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert
Copy link
Contributor

Thank you @chair6,

I was going to do this today actually. Given that the acceptance tests have passed, I feel pretty good about merging this in.

@t-eckert t-eckert requested review from a team, jmurret, ishustava and kschoche and removed request for a team and ishustava April 26, 2022 16:09
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you!

@finnigja finnigja merged commit 9033dab into main Apr 27, 2022
@finnigja finnigja deleted the bump_deps branch April 27, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants