Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autogen gossip name mismatch #1196

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Apr 29, 2022

Changes proposed in this PR:

  • Fixes issue Gossip encryption key secret name mismatched when set autoGenerate=true with a custom chart name #1186 where the create federation secret job was failing due to it looking up the autogenerated gossip encryption key by the name consul-gossip-encryption-key and not using the release name.
  • Added a test to catch that the release name is used when looking up the gossip key. This does not test the integration, but only that the release name itself is used in the gossip key name.
  • Small tidy where I changed "Secet" to "Secret" in the BATS tests.

How I've tested this PR:

From the charts directory, run bats test/unit/create-federation-secret-job.bats.

How I expect reviewers to test this PR:

Using BATS tests as well.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert t-eckert requested review from kschoche, a team and ndhanushkodi and removed request for a team April 29, 2022 16:19
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants