Enable auto_reload_config only when Vault is enabled. #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
a team,
jmurret and
t-eckert
and removed request for
a team
jmurret
reviewed
May 5, 2022
thisisnotashwin
force-pushed
the
ashwin/reload-vault-config
branch
from
f05a707
to
e1ed606
Compare
lkysow
approved these changes
May 5, 2022
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ## UNRELEASED | |||
|
|
|||
| BREAKING CHANGES: | |||
| * Helm | |||
| * Requires Consul 1.12.0+. If you're not using the Vault integration then 0.43.1 will support Consul 1.11.x. | |||
There was a problem hiding this comment.
Suggested change
| * Requires Consul 1.12.0+. If you're not using the Vault integration then 0.43.1 will support Consul 1.11.x. | |
| * If you're using the Vault integration, requires Consul 1.12.0+. |
thisisnotashwin
force-pushed
the
ashwin/reload-vault-config
branch
from
e1ed606
to
f87568c
Compare
thisisnotashwin
force-pushed
the
ashwin/reload-vault-config
branch
from
f87568c
to
a17da77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: