Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customization of snapshot agent interval #1235

Merged
merged 5 commits into from
May 25, 2022
Merged

Allow customization of snapshot agent interval #1235

merged 5 commits into from
May 25, 2022

Conversation

relusc
Copy link
Contributor

@relusc relusc commented May 24, 2022

Changes proposed in this PR:

How I've tested this PR:
unit tests

How I expect reviewers to test this PR:
the same way as I did ;)

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

lkysow
lkysow reviewed May 24, 2022
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just some small changes.

charts/consul/values.yaml Outdated Show resolved Hide resolved
charts/consul/values.yaml Outdated Show resolved Hide resolved
charts/consul/test/unit/client-snapshot-agent-deployment.bats Outdated Show resolved Hide resolved
charts/consul/test/unit/client-snapshot-agent-deployment.bats Outdated Show resolved Hide resolved
charts/consul/test/unit/client-snapshot-agent-deployment.bats Outdated Show resolved Hide resolved
Rene Schach and others added 3 commits May 25, 2022 07:18
@lkysow
Apply suggestions from code review @lkysow
56ff3f9 
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
@relusc
Revert reformat of values.yaml
8849d40
@relusc
Update unit tests
6fe789a
@relusc
Copy link
Contributor Author

relusc commented May 25, 2022

thanks for the review @lkysow :) I think of all of your comments have been addressed

@relusc relusc requested a review from lkysow May 25, 2022 05:32
lkysow
lkysow approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

kschoche
kschoche approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it looks great!

@kschoche kschoche merged commit 060a2a6 into hashicorp:main May 25, 2022
@kschoche kschoche mentioned this pull request May 25, 2022
Merged
2 tasks
kschoche added a commit that referenced this pull request May 25, 2022
@kschoche
update changelog for community pr GH-1235 (#1243)
91d87f0 
* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkysow lkysow lkysow approved these changes

@kschoche kschoche kschoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@relusc @lkysow @kschoche