-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customization of snapshot agent interval #1235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just some small changes.
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
thanks for the review @lkysow :) I think of all of your comments have been addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, it looks great!
Changes proposed in this PR:
1h
as stated in the docs https://www.consul.io/commands/snapshot/agent#intervalHow I've tested this PR:
unit tests
How I expect reviewers to test this PR:
the same way as I did ;)
Checklist: