Removing agent:read ACL permissions from mesh gateways #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
kschoche and
ishustava
and removed request for
a team
lkysow
changed the title
ishustava
approved these changes
Sep 2, 2022
|
Do we need a changelog entry on this? |
|
Yes a changelog is needed. |
This is only necessary to look up the gRPC port, but since we're setting CONSUL_GRPC_ADDR we don't need this permission
lkysow
force-pushed
the
lkysow/remove-agent-policy
branch
from
4549283
to
e661e3c
Compare
t-eckert
pushed a commit
that referenced
this pull request
Oct 31, 2022
This is only necessary to look up the gRPC port, but since we're setting CONSUL_GRPC_ADDR we don't need this permission
thisisnotashwin
pushed a commit
that referenced
this pull request
Oct 31, 2022
This is only necessary to look up the gRPC port, but since we're setting CONSUL_GRPC_ADDR we don't need this permission
thisisnotashwin
pushed a commit
that referenced
this pull request
Nov 1, 2022
This is only necessary to look up the gRPC port, but since we're setting CONSUL_GRPC_ADDR we don't need this permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
agent_prefixACL policy for mesh gateways.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: